Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document addition of wl-copy/wl-paste usage in Set/Get-Clipboard #11267

Conversation

helpimnotdrowning
Copy link

@helpimnotdrowning helpimnotdrowning commented Jul 13, 2024

PR Summary

Add note for wl-copy/wl-paste (wl-clipboard) dependency in Get/Set-Clipboard alongside existing xclip dependency for issue

Note: In following the main Powershell CONTRIBUTING.md, I tried using Update-MarkdownHelp on the modified doc files, but it seemed to change far more lines than I had changed myself, so I haven't included it's changes. If I absolutely need to include those, I can.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@helpimnotdrowning
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

Learn Build status updates of commit 4578b2e:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Management/Get-Clipboard.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Management/Set-Clipboard.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@sdwheeler
Copy link
Contributor

sdwheeler commented Jul 13, 2024

I just noticed that this is pending a code change you submitted. Holding the doc PR until the code PR is merged.

@sdwheeler sdwheeler closed this Jul 13, 2024
@sdwheeler sdwheeler added the do-not-merge Tag - closed without merging label Jul 13, 2024
@helpimnotdrowning
Copy link
Author

Sorry, this was made to tag along with my PR in Powershell/Powershell where I add this feature: PowerShell/PowerShell#24049 . Please re-open this PR.

@sdwheeler sdwheeler added hold-for-pr Waiting - for PR merge hold-for-release Waiting - for next release and removed do-not-merge Tag - closed without merging labels Jul 13, 2024
@sdwheeler sdwheeler reopened this Jul 14, 2024
Copy link
Contributor

Learn Build status updates of commit 4578b2e:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Management/Get-Clipboard.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Management/Set-Clipboard.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler force-pushed the fix-wayland-clipboard branch from 4578b2e to 5c1c2c5 Compare August 12, 2024 19:05
Copy link
Contributor

Learn Build status updates of commit 5c1c2c5:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Management/Get-Clipboard.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Management/Set-Clipboard.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls do as well

@sdwheeler
Copy link
Contributor

Closing this PR. The Working Groups have reviewed the code change and have suggested a different design.

@sdwheeler sdwheeler closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold-for-pr Waiting - for PR merge hold-for-release Waiting - for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants