Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call operator: reference changes since v7.3 with PSnativeCommandArgumentPassing becoming mainstream #11071

Merged
merged 3 commits into from
May 7, 2024

Conversation

stephanadler1
Copy link
Contributor

Version 7.3 made an experimental change mainstream that significantly changes how arguments are encapsulated and passed to native commands. While this normally doesn't make a difference there are enough subtle breakages documented on the Web that warrant that this change should be documented in the reference documentation and not just in files describing experimental features.

PR Summary

The change adds a paragraph similar to the one in https://learn.microsoft.com/en-us/powershell/scripting/learn/experimental-features?view=powershell-7.4#psnativecommandargumentpassing. There are numerous issu reports on the Web where poepe are describing odd behaviors when invoking native commands. For example Azure/azure-storage-azcopy#796.
This change would make it more obvious to discover, in addition to the already existing references in

Oddly enough both pages still reference to PSnativeCommandArgumentPassing as being experimental.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Copy link
Contributor

Learn Build status updates of commit 55762fc:

💡 Validation status: suggestions

File Status Preview URL Details
reference/7.4/Microsoft.PowerShell.Core/About/about_Operators.md 💡Suggestion View (powershell-7.4) Details

reference/7.4/Microsoft.PowerShell.Core/About/about_Operators.md

  • Line 250, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/reference/docs-conceptual/learn/experimental-features.md#psnativecommandargumentpassing' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

github-actions bot commented May 5, 2024

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

Copy link
Contributor

Learn Build status updates of commit 4e0016d:

✅ Validation status: passed

File Status Preview URL Details
reference/7.4/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-7.4)
reference/7.5/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler
Copy link
Contributor

The invocation operator (&) has nothing to do with change in parsing for native commands. The operator adheres to the same parsing rules, which are already documented in
Passing arguments that contain quote characters
for each version of PowerShell.

stephanadler1 and others added 3 commits May 7, 2024 13:03
Version 7.3 made an experimental change mainstream that significantly changes how arguments are encapsulated and passed to native commands. While this normally doesn't make a difference there are enough subtle breakages documented on the Web that warrant that this change should be documented in the reference documentation and not just in files describing experimental features.
Copy link
Contributor

Learn Build status updates of commit 1c1e145:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-7.4)
reference/7.5/Microsoft.PowerShell.Core/About/about_Operators.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit 847ef5b into MicrosoftDocs:main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants