Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCT documentation update v8.1.240328-rc #393

Merged

Conversation

Arlodotexe
Copy link
Contributor

@Arlodotexe Arlodotexe commented Mar 29, 2024

This PR updates the Windows Community Toolkit documentation to align with the 8.1.240328-rc prerelease.

Documentation and ToC was generated by our ./tooling/Build-Toolkit-Docs.ps1 build script, detailed here.

The index.md and getting-started.md, which are not present in the generated docs, were manually re-added to the ToC, as well as the links at the bottom.

@Arlodotexe
Copy link
Contributor Author

@microsoft-github-policy-service agree

@michael-hawker
Copy link
Contributor

Thanks Arlo, not sure why we're not seeing the doc build run to give us a preview...

We also need the map of the moved docs, so we can get redirects in place.

@JasonWHowell
Copy link

@michael-hawker click here and then you can see the build previews:

image

image

In the build log there are View links for each changed file.
For example: https://review.learn.microsoft.com/en-us/dotnet/communitytoolkit/windows/colorpicker/index?branch=pr-en-us-393

@michael-hawker
Copy link
Contributor

Thanks @JasonWHowell for the info, I see that now. I wasn't part of the discussion when the flag to bubble it up with the bot was turned off here: 51d7ca4 - so I'm following up with our co-owners of the repo.

The bot post certainly made it clearer when there were warnings and things we should be fixing before committing. FYI @jfversluis, started a thread on teams with the team. 😊

@Arlodotexe
Copy link
Contributor Author

Example of redirects can be found here

This comment was marked as outdated.

@jfversluis
Copy link
Contributor

Voila, careful what you wish for... A lot of warnings to fix 😜

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@Arlodotexe
Copy link
Contributor Author

Arlodotexe commented Apr 15, 2024

I've added the redirects and followed the existing formatting, not sure why the warnings are still showing there.

This comment was marked as outdated.

@Arlodotexe
Copy link
Contributor Author

Arlodotexe commented Apr 15, 2024

I've added the redirects and followed the existing formatting, not sure why the warnings are still showing there.

The issue persists.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 1b77d4c:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/windows/Extensions/DispatcherQueueExtensions.md ⚠️Warning View Details
docs/windows/Extensions/ShadowAnimations.md ⚠️Warning View Details
docs/windows/Sizers/GridSplitter.md ⚠️Warning View Details
docs/windows/Converters/index.md 💡Suggestion View Details
docs/windows/Extensions/FrameworkElementExtensions.md 💡Suggestion View Details
.openpublishing.redirection.json ✅Succeeded View
docs/windows/Animations/Animations.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/AnimationSet.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/index.md ✅Succeeded View
docs/windows/Behaviors/AnimationSet.md ✅Succeeded View
docs/windows/Behaviors/Behaviors.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Behaviors/HeaderBehaviors.md ✅Succeeded View
docs/windows/Behaviors/index.md ✅Succeeded View
docs/windows/Behaviors/StackedNotificationsBehavior.md ✅Succeeded View
docs/windows/CameraPreview/CameraPreview.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/CameraPreview/index.md ✅Succeeded View
docs/windows/Collections/AdvancedCollectionView.md ✅Succeeded View
docs/windows/Collections/IncrementalLoadingCollection.md ✅Succeeded View
docs/windows/ColorPicker/index.md ✅Succeeded View
docs/windows/Converters/Converters.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/DeveloperTools.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/index.md ✅Succeeded View
docs/windows/Extensions/AttachedDropShadow.md ✅Succeeded View
docs/windows/Extensions/ListViewExtensions.md ✅Succeeded View
docs/windows/Extensions/TextBoxExtensions.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.

docs/windows/Extensions/DispatcherQueueExtensions.md

  • Line 54, Column 19: [Warning: file-not-found - See documentation] Invalid file link: '..\helpers\DispatcherHelper.md'.

docs/windows/Extensions/ShadowAnimations.md

  • Line 17, Column 359: [Warning: file-not-found - See documentation] Invalid file link: '../animations/AnimationBuilder.md'.

docs/windows/Sizers/GridSplitter.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 4, Column 1: [Warning: yaml-header-syntax-error - See documentation] While parsing a block mapping, did not find expected key.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/windows/Converters/index.md

  • Line 99, Column 67: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /dotnet/api/system.string.format?view=netstandard-2.0

docs/windows/Extensions/FrameworkElementExtensions.md

  • Line 106, Column 39: [Suggestion: learn-site-link-broken - See documentation] Link '/uwp/input-and-devices/mouse-interactions#cursors' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 1ba9296:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/windows/Extensions/DispatcherQueueExtensions.md ⚠️Warning View Details
docs/windows/Extensions/ShadowAnimations.md ⚠️Warning View Details
docs/windows/Sizers/GridSplitter.md ⚠️Warning View Details
docs/windows/Converters/index.md 💡Suggestion View Details
docs/windows/Extensions/FrameworkElementExtensions.md 💡Suggestion View Details
.openpublishing.redirection.json ✅Succeeded View
docs/windows/Animations/Animations.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/AnimationSet.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/index.md ✅Succeeded View
docs/windows/Behaviors/AnimationSet.md ✅Succeeded View
docs/windows/Behaviors/Behaviors.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Behaviors/HeaderBehaviors.md ✅Succeeded View
docs/windows/Behaviors/index.md ✅Succeeded View
docs/windows/Behaviors/StackedNotificationsBehavior.md ✅Succeeded View
docs/windows/CameraPreview/CameraPreview.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/CameraPreview/index.md ✅Succeeded View
docs/windows/Collections/AdvancedCollectionView.md ✅Succeeded View
docs/windows/Collections/IncrementalLoadingCollection.md ✅Succeeded View
docs/windows/ColorPicker/index.md ✅Succeeded View
docs/windows/Converters/Converters.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/DeveloperTools.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/index.md ✅Succeeded View
docs/windows/Extensions/AttachedDropShadow.md ✅Succeeded View
docs/windows/Extensions/ListViewExtensions.md ✅Succeeded View
docs/windows/Extensions/TextBoxExtensions.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.

docs/windows/Extensions/DispatcherQueueExtensions.md

  • Line 54, Column 19: [Warning: file-not-found - See documentation] Invalid file link: '..\helpers\DispatcherHelper.md'.

docs/windows/Extensions/ShadowAnimations.md

  • Line 17, Column 359: [Warning: file-not-found - See documentation] Invalid file link: '../animations/AnimationBuilder.md'.

docs/windows/Sizers/GridSplitter.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 4, Column 1: [Warning: yaml-header-syntax-error - See documentation] While parsing a block mapping, did not find expected key.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs/windows/Converters/index.md

  • Line 99, Column 67: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /dotnet/api/system.string.format?view=netstandard-2.0

docs/windows/Extensions/FrameworkElementExtensions.md

  • Line 106, Column 39: [Suggestion: learn-site-link-broken - See documentation] Link '/uwp/input-and-devices/mouse-interactions#cursors' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Arlodotexe added a commit to Arlodotexe/CommunityToolkit that referenced this pull request Apr 30, 2024
Copy link

Learn Build status updates of commit d28bb67:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/windows/Animations/Animations.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/AnimationSet.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/index.md ✅Succeeded View
docs/windows/Behaviors/AnimationSet.md ✅Succeeded View
docs/windows/Behaviors/Behaviors.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Behaviors/HeaderBehaviors.md ✅Succeeded View
docs/windows/Behaviors/index.md ✅Succeeded View
docs/windows/Behaviors/StackedNotificationsBehavior.md ✅Succeeded View
docs/windows/CameraPreview/CameraPreview.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/CameraPreview/index.md ✅Succeeded View
docs/windows/Collections/AdvancedCollectionView.md ✅Succeeded View
docs/windows/Collections/IncrementalLoadingCollection.md ✅Succeeded View
docs/windows/ColorPicker/index.md ✅Succeeded View
docs/windows/Converters/Converters.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Converters/index.md ✅Succeeded View
docs/windows/DeveloperTools/DeveloperTools.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/index.md ✅Succeeded View
docs/windows/Extensions/AttachedDropShadow.md ✅Succeeded View
docs/windows/Extensions/DispatcherQueueExtensions.md ✅Succeeded View
docs/windows/Extensions/FrameworkElementExtensions.md ✅Succeeded View
docs/windows/Extensions/ListViewExtensions.md ✅Succeeded View
docs/windows/Extensions/ShadowAnimations.md ✅Succeeded View
docs/windows/Extensions/TextBoxExtensions.md ✅Succeeded View
docs/windows/HeaderedControls/HeaderedContentControl.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@michael-hawker
Copy link
Contributor

Awesome, thanks @Arlodotexe! I believe everything in main goes live pretty quick, so we should wait to merge this until we're ready to release, right?

Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request May 17, 2024
Copy link

Learn Build status updates of commit 4d78a48:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/windows/Animations/Animations.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/AnimationSet.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/index.md ✅Succeeded View
docs/windows/Behaviors/AnimationSet.md ✅Succeeded View
docs/windows/Behaviors/Behaviors.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Behaviors/HeaderBehaviors.md ✅Succeeded View
docs/windows/Behaviors/index.md ✅Succeeded View
docs/windows/Behaviors/StackedNotificationsBehavior.md ✅Succeeded View
docs/windows/CameraPreview/CameraPreview.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/CameraPreview/index.md ✅Succeeded View
docs/windows/Collections/AdvancedCollectionView.md ✅Succeeded View
docs/windows/Collections/IncrementalLoadingCollection.md ✅Succeeded View
docs/windows/ColorPicker/index.md ✅Succeeded View
docs/windows/Converters/Converters.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Converters/index.md ✅Succeeded View
docs/windows/DeveloperTools/DeveloperTools.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/index.md ✅Succeeded View
docs/windows/Extensions/AttachedDropShadow.md ✅Succeeded View
docs/windows/Extensions/DispatcherQueueExtensions.md ✅Succeeded View
docs/windows/Extensions/FrameworkElementExtensions.md ✅Succeeded View
docs/windows/Extensions/ListViewExtensions.md ✅Succeeded View
docs/windows/Extensions/ShadowAnimations.md ✅Succeeded View
docs/windows/Extensions/TextBoxExtensions.md ✅Succeeded View
docs/windows/HeaderedControls/HeaderedContentControl.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@michael-hawker michael-hawker force-pushed the windows/update/8.1.240329-rc branch from 4d78a48 to 68e147c Compare August 21, 2024 16:14
Copy link

Learn Build status updates of commit 68e147c:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/windows/Animations/Animations.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/AnimationSet.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Animations/index.md ✅Succeeded View
docs/windows/Behaviors/AnimationSet.md ✅Succeeded View
docs/windows/Behaviors/Behaviors.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Behaviors/HeaderBehaviors.md ✅Succeeded View
docs/windows/Behaviors/index.md ✅Succeeded View
docs/windows/Behaviors/StackedNotificationsBehavior.md ✅Succeeded View
docs/windows/CameraPreview/CameraPreview.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/CameraPreview/index.md ✅Succeeded View
docs/windows/Collections/AdvancedCollectionView.md ✅Succeeded View
docs/windows/Collections/IncrementalLoadingCollection.md ✅Succeeded View
docs/windows/ColorPicker/index.md ✅Succeeded View
docs/windows/Converters/Converters.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/Converters/index.md ✅Succeeded View
docs/windows/DeveloperTools/DeveloperTools.md ✅Succeeded n/a (file deleted or renamed)
docs/windows/DeveloperTools/index.md ✅Succeeded View
docs/windows/Extensions/AttachedDropShadow.md ✅Succeeded View
docs/windows/Extensions/DispatcherQueueExtensions.md ✅Succeeded View
docs/windows/Extensions/FrameworkElementExtensions.md ✅Succeeded View
docs/windows/Extensions/ListViewExtensions.md ✅Succeeded View
docs/windows/Extensions/ShadowAnimations.md ✅Succeeded View
docs/windows/Extensions/TextBoxExtensions.md ✅Succeeded View
docs/windows/HeaderedControls/HeaderedContentControl.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@michael-hawker michael-hawker merged commit 2931111 into MicrosoftDocs:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants