stop "setopt nullglob" from leaking into user's shell #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
install_requirements
function, we do asetopt nullglob
and never attempt to set it back to how it was set previously, which means that the behavior of the user's shell as a whole can (and likely will, as this isn't the default) change globbing behavior without the user's knowledge or consent.Adding a
setopt localoptions
before changing any options will cause changed options to reset to their original values when the enclosing function exits, stopping this option change from leaking into the user's shell. SeeLOCAL_OPTIONS
at https://zsh.sourceforge.io/Doc/Release/Options.html for more details