Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide suggestion to run mkvenv #167

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

seancmonahan
Copy link

@seancmonahan seancmonahan commented Jan 20, 2022

Set the environment variable AUTOSWITCH_HIDE_MKVENV_SUGGESTION to silence the message Python virtualenv project detected. Run mkvenv to setup autoswitching when cding to a Python project without an initialized virtual environment.

@seancmonahan
Copy link
Author

I can squash my 5 commits and resubmit as a cleaner PR if needed.

Copy link
Owner

@MichaelAquilina MichaelAquilina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Could you please write one or more test cases to show this working?

Let me know if you need a hand with this.

Squashing would be ideal if you can do it :)

@seancmonahan
Copy link
Author

Sure, I will write some test cases for it! Might be a couple days until I am able to get them up. I'll look at existing ZUnit tests to get a sense of what to write.

@MichaelAquilina
Copy link
Owner

Hello @seancmonahan :) would you like me to take over this PR or would you still like to try finish it off yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants