Drop gitleaks from pre-commit config. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaleh
changed the title
|
That linter failure? Why? |
|
Seems to be an issue with the caching mechanism. However it does seem like gcc is needed (might have been a dependency of go which is now removed in your PR). I think adding gcc to the apk install step should solve this problem |
|
Ok the actual issue was that black broke due to a dependency releasing an incompatible version: psf/black#2964 I've pushed a fix on main so you can rebase to make the issue go away |
# Conflicts: # .pre-commit-config.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitleaks is a bit much for the project. There is not much sensitive to watch out for.