Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'allowlist' and 'denylist' to english dictionary list #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 'allowlist' and 'denylist' to english dictionary list #67

wants to merge 1 commit into from

Conversation

shaleh
Copy link
Contributor

@shaleh shaleh commented Mar 24, 2022

More from #55.

MichaelAquilina
MichaelAquilina reviewed Mar 26, 2022
View reviewed changes
Copy link
Owner

@MichaelAquilina MichaelAquilina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would agree these as being in the en_US dictionary.

I would say these are specific to this project and should be added to the projects specific allow list

@djmattyg007
Copy link
Contributor

If that's true, why can whitelist remain in the en_US dictionary?

@MichaelAquilina
Copy link
Owner

why can whitelist remain in the en_US dictionary?

it shoudnt either. I dont think I ever edited this words list file (I generated it from aspell). If it is in there, its either that I added it and forgot (and now I think its the wrong thing to do) or it was already there in the first place.

@shaleh shaleh force-pushed the add-allow-and-denylist-to-english-dictionary branch from 0bc93f3 to 8b6f921 Compare March 28, 2022 17:45
@shaleh
Copy link
Contributor Author

shaleh commented Mar 28, 2022

Which dictionary do they belong in if not the general en_US.txt? technical.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelAquilina MichaelAquilina MichaelAquilina left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaleh @djmattyg007 @MichaelAquilina