Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requests to cached agendas #1149

Open
hancush opened this issue Jul 24, 2024 · 1 comment
Open

Fix requests to cached agendas #1149

hancush opened this issue Jul 24, 2024 · 1 comment
Assignees
@hancush

Comments

@hancush
Copy link
Collaborator

hancush commented Jul 24, 2024 •
edited
Loading

When a document URL contains URL parameters, sometimes PIC gets confused and parses the filename parameter we pass separately as part of the document URL querystring.

https://datamade.sentry.io/issues/4494469767/?alert_rule_id=1176635&alert_type=issue&notification_uuid=600a4283-74fe-4231-bbe8-9c46b69600a5&project=64504&referrer=slack
@hancush hancush self-assigned this Jul 24, 2024
@hancush hancush moved this from 🆕 New issues to 📤 Review/QA in boardagendas.metro.net - Monthly priorities Jul 24, 2024
@hancush hancush mentioned this issue Jul 24, 2024
Merged
hancush added a commit that referenced this issue Jul 29, 2024
@hancush
Merge pull request #1150 from Metro-Records/hcg/cache-fix
366a676 
Reverse order of cache doc parameters, closes #1149
@github-project-automation github-project-automation bot moved this from 📤 Review/QA to ✅ Done in boardagendas.metro.net - Monthly priorities Jul 29, 2024
@hancush
Copy link
Collaborator Author

hancush commented Aug 6, 2024

Thought this was fixed, but it wasn't. Reopening.

@hancush hancush reopened this Aug 6, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New issues in boardagendas.metro.net - Monthly priorities Aug 6, 2024
@hancush hancush moved this from 🆕 New issues to 📝 In Progress in boardagendas.metro.net - Monthly priorities Aug 6, 2024
@hancush hancush mentioned this issue Aug 13, 2024
Merged
hancush added a commit to datamade/property-image-cache that referenced this issue Aug 27, 2024
@hancush
Check for required querystring parameters, handle invalid values
f701c8a 
Connects Metro-Records/la-metro-councilmatic#1149
@hancush hancush mentioned this issue Aug 27, 2024
Merged
@hancush hancush moved this from 📝 In Progress to 📤 Review/QA in boardagendas.metro.net - Monthly priorities Sep 3, 2024
@hancush hancush moved this from 📤 Review/QA to ✅ Done in boardagendas.metro.net - Monthly priorities Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hancush hancush

Labels
None yet
Projects
boardagendas.metro.net - Monthly priorities
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hancush