Merge pull request #1137 from Metro-Records/patch/manual-broadcast

Prevent broadcast creation if a proper one already exists

.gitignore

@@ -24,3 +24,5 @@ debug.log
 
 lametro/secrets.py
 .env.local
+
+.venv

lametro/views.py

@@ -316,15 +316,22 @@ def manual_event_live_link(request, event_slug):
     Toggle a manually live event broadcast link
     """
     event = LAMetroEvent.objects.get(slug=event_slug)
-    broadcasts = event.broadcast.filter(is_manually_live=True)
+    has_regular_broadcasts = event.broadcast.filter(is_manually_live=False).exists()
+    manual_broadcasts = event.broadcast.filter(is_manually_live=True)
 
-    if broadcasts.count() == 0:
+    if manual_broadcasts.count() == 0 and not has_regular_broadcasts:
         # Create a manual broadcast
         EventBroadcast.objects.create(event=event, is_manually_live=True)
         messages.success(request, f"Link for {event.name} has been manually published.")
+    elif has_regular_broadcasts:
+        messages.info(
+            request,
+            f"The event {event.name} already has a proper broadcast. "
+            + "A manual broadcast cannot be created.",
+        )
     else:
         # Delete that broadcast
-        for b in broadcasts:
+        for b in manual_broadcasts:
             b.delete()
         messages.success(request, f"Link for {event.name} has been unpublished.")
 

tests/test_events.py

@@ -763,7 +763,7 @@ def test_manual_broadcast_permissions(event, client, admin_client, mocker):
     """
     Check that only authenticated users can make/delete manual broadcasts
     """
-    test_event = event.build()
+    test_event = event.build(has_broadcast=False)
     mock_api_representation = mocker.patch(
         "lametro.models.SourcesMixin.api_representation",
         new_callable=mocker.PropertyMock,
@@ -803,7 +803,7 @@ def test_manually_broadcasted_events(event, admin_client, mocker):
     """
     Check that events marked as having a manual broadcast are counted as being current/live.
     """
-    test_event = event.build()
+    test_event = event.build(has_broadcast=False)
     mock_api_representation = mocker.patch(
         "lametro.models.SourcesMixin.api_representation",
         new_callable=mocker.PropertyMock,