Fix CI integration test #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm run test-integration` uses Electron and therefore needs a display to work properly. Other changes: - Add a build step to make sure `npm run build` is always ran (dist/ could change without a package-lock.json change, I think) - Cache: add ~/.npm and fix /tmp/.__tmp_int (test-meteor-desktop path) - Trigger action for all pull requests, not only those against master - Update actions/checkout to v4 - Renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated integration tests should now pass on Github actions.
As hypothesized, the problem was that
npm run test-integrationlaunches Electron and therefore needs a display to work properly, but the CI workflow runs on a headless Linux OS. Running the test-integration script through Xvfb (a virtual X11 display server) solved the issue.I also made other minor improvements to the test workflow, see commit message details.
Related commit: Meteor and Node should now be 2.6.1 and 14 everywhere (it was still 2.6 and 12 in a few places).