Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata object #52

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Metadata object #52

wants to merge 5 commits into from

Conversation

cfkanesan
Copy link
Collaborator

Purpose

Use the standalone metadata object to store field metadata instead of the byte string of a sample GRIB message. This change was required by a breaking change to the write function which was used to update the message attribute.

Code changes:

  • DataArray objects representing a field no longer have the message attribute but now have a metadata attribute that is an instance of StandAloneGribMetadata from earthkit-data.

Requirements changes:

  • earthkit-data range extended to >=0.5.6,<1

Copy link
Collaborator

@frazane frazane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor comments about missing type hints.

src/meteodatalab/metadata.py Outdated Show resolved Hide resolved
src/meteodatalab/metadata.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ninaburg ninaburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants