Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pressure level metadata #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix pressure level metadata #46

wants to merge 1 commit into from

Conversation

cosunae
Copy link
Contributor

@cosunae cosunae commented Oct 24, 2024

Purpose

When using interpolate_k2p with 50 hPa as parameters, the output written in grib comes with wrong metadata (by factor 100)
23 typeOfFirstFixedSurface = 100 [Isobaric surface (Pa) (grib2/tables/11/4.5.table) ]
24 scaleFactorOfFirstFixedSurface = 0
25-28 scaledValueOfFirstFixedSurface = 500000

The problem is, I think, that the derived key "level" is interpreted as hPa

Code changes:

  • Modify the coordinates so that 'z' is represented in hPa

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README)
  • Unit tests are added or updated for non-operator code
  • New operators are properly tested

Additionally, if the PR updates the version of the package

  • The new version is properly set
  • A Tag will be created after the bump

Review

For the review process follow the guidelines at Checklist

@cfkanesan
Copy link
Collaborator

Can you provide a reproducible example?

@cfkanesan
Copy link
Collaborator

I think it's fine to default to hPa as a unit for the pressure levels but please set the typeOfLevel to isobaricInhPa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants