Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename compose files to new canonical format #140

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Conversation

omarlopesino
Copy link
Member

@omarlopesino omarlopesino force-pushed the feature/compose-update branch from 7e98e9a to 47cbc56 Compare April 1, 2024 07:17
@omarlopesino
Copy link
Member Author

omarlopesino commented Apr 1, 2024

I've just checked that if .env contains DOCKER_COMPOSE_CMD defined like this

DOCKER_COMPOSE_CMD=docker compose

It appears the following error:

 Failed to parse dotenv file. Encountered unexpected whitespace

I've tried to fix it by:

  1. Encapsulating DOCKER_COMPOSE_CMD with quotes
    DOCKER_COMPOSE_CMD=docker compose
  2. Modifying boilerplate assistant command to get the docker compose command:
    $this->dockerComposeCmd = trim(shell_exec("grep ^DOCKER_COMPOSE_CMD= .env.example | cut -f2 -d= | tr -d '"'"));

The problem is that the Makefile commands stop working, because they expect DOCKER_COMPOSE_CMD to not be encapsulated. At this point, I don't know exactly how to fix it.

Can we just stop supporting compose V1 as it is deprecated' THat would all the problems by just using docker compose and never docker-compose

@rsanzante
Copy link
Member

I agree, we can drop v1.

@rsanzante
Copy link
Member

I've dropped support for v2 in the assistant. and now tests are green!

@rsanzante rsanzante merged commit 56b81e9 into 3.x Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants