Skip to content

Commit

Permalink
Remove phantomjs support
Browse files Browse the repository at this point in the history
Phantomjs was used for phpunit drupal tests but now the tool is
deprecated and nightwatch / webdriver are being used instead
  • Loading branch information
omarlopesino committed Mar 25, 2024
1 parent 389d68f commit 911f272
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
4 changes: 0 additions & 4 deletions docker-compose.override.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,6 @@ services:
- "traefik.http.services.${PROJECT_NAME}_mailhog.loadbalancer.server.port=8025"
- "traefik.http.routers.${PROJECT_NAME}_mailhog.rule=Host(`mailhog.${PROJECT_BASE_URL}`)"

# phantomjs:
# volumes:
# - ./:/var/www/html:cached # User-guided caching

lighthouse:
volumes:
- ./tests/functional/lighthouse/lighthouserc.js:/home/lhci/reports/lighthouserc.js
Expand Down
10 changes: 0 additions & 10 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,6 @@ services:
# - "--verbose"
# - "--whitelisted-ips="


# phantomjs:
# image: wernight/phantomjs:${PHANTOMJS_VERSION}
# container_name: "${PROJECT_NAME}_phantomjs"
# depends_on:
# - php
# - apache
# entrypoint: phantomjs
# command: "--ssl-protocol=any --ignore-ssl-errors=true /var/www/html/vendor/jcalderonzumba/gastonjs/src/Client/main.js 8510 1024 768"

mailhog:
image: mailhog/mailhog
container_name: "${PROJECT_NAME}_mailhog"
Expand Down
2 changes: 0 additions & 2 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
<env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/>
<!-- Example for changing the driver class for mink tests MINK_DRIVER_CLASS value: 'Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver' -->
<!-- Example for changing the driver args to mink tests MINK_DRIVER_ARGS value: '["http://127.0.0.1:8510"]' -->
<!-- Example for changing the driver args to phantomjs tests MINK_DRIVER_ARGS_PHANTOMJS value: '["http://127.0.0.1:8510"]' -->
<!-- Example for changing the driver args to webdriver tests MINK_DRIVER_ARGS_WEBDRIVER value: '["firefox", null, "http://localhost:4444/wd/hub"]' -->
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", {"browserName":"chrome","chromeOptions":{"args":["--disable-gpu","--headless"]}}, "http://hub:4444/wd/hub"]'/>
<env name="MINK_DRIVER_ARGS_PHANTOMJS" value='["http://phantomjs:8510"]'/>
</php>
<testsuites>
<testsuite name="default">
Expand Down

0 comments on commit 911f272

Please sign in to comment.