feat: Allow passing btoa for mobile execution service #2923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing in a
btoa
(base64 encoding) function to the mobile execution service. This lets us use native code for the encoding on mobile. We use base64 encoding to prevent XSS due to the weird nature of how React Native WebViewpostMessage
works, but currently do not use a native implementation for base64. This is mostly problematic for larger messages, such as theexecuteSnap
payload, that end up taking over half a second for some example Snaps. This problem would only grow for larger Snaps. We already usereact-native-quick-base64
for other purposes in mobile, so dropping it into Snaps will be quite simple.Progresses #2910