Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Address in Card title. #2894

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

GuillaumeRx
Copy link
Contributor

This PR adds support for the Address component as a title in the Card component.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 19, 2024 10:06
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (0b19875) to head (bbf5985).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2894   +/-   ##
=======================================
  Coverage   94.48%   94.49%           
=======================================
  Files         486      486           
  Lines       10397    10401    +4     
  Branches     1594     1595    +1     
=======================================
+ Hits         9824     9828    +4     
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@GuillaumeRx GuillaumeRx merged commit 2d6575e into main Nov 19, 2024
166 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-address-card-title branch November 19, 2024 13:14
GuillaumeRx added a commit to MetaMask/metamask-extension that referenced this pull request Nov 20, 2024
## **Description**

This PR adds support for the `Address` component in the `Card` title
following this PR: MetaMask/snaps#2894

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28539?quickstart=1)

## **Related issues**

## **Manual testing steps**

```jsx
<Card
  image='foo'
  title={<Address address={your address in MetaMask} displayName avatar={false} />}
  description='bar'
  extra='foobar'
/>
```

## **Screenshots/Recordings**


![241119_12h11m39s_screenshot](https://github.com/user-attachments/assets/9b32d7f6-aef4-415b-800a-350cde6696d8)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants