Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Patch @metamask/utils v8.0.0 with https://github.com/MetaMask/utils/pull/134 #1705

Closed

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Aug 29, 2023

Compatibility-validation of MetaMask/utils#134

Based on #1700 + #1706

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/[email protected]

@legobeat legobeat force-pushed the deps-metamask-utils-8-test-134 branch from f3cebb6 to b9ab08e Compare August 29, 2023 23:32
@socket-security
Copy link

socket-security bot commented Aug 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @types/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @types/[email protected]

unmaintained ok

@legobeat legobeat force-pushed the deps-metamask-utils-8-test-134 branch 3 times, most recently from 8065ff7 to 083b98b Compare August 30, 2023 01:27
@legobeat
Copy link
Contributor Author

legobeat commented Aug 30, 2023

The one outstanding type error is actually in a dependency:

Error: node_modules/@metamask/permission-controller/dist/rpc-methods/getPermissions.d.ts(4,89): error TS2344: Type 'undefined' does not satisfy the constraint 'JsonRpcParams'.

@metamask/utils 8.0.0 made undefined into not valid for JsonRpcParams.

Corresponding PR for @metamask/permission-controller: MetaMask/core#1640

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a596bee) 95.87% compared to head (1d152c5) 95.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1705   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         239      239           
  Lines        5401     5401           
  Branches      836      836           
=======================================
  Hits         5178     5178           
  Misses        223      223           
Files Changed Coverage Δ
packages/snaps-utils/src/cronjob.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-metamask-utils-8-test-134 branch from 74aeff3 to 1d152c5 Compare August 30, 2023 04:37
@legobeat legobeat closed this Sep 6, 2023
@legobeat legobeat deleted the deps-metamask-utils-8-test-134 branch September 6, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant