Fix unpacking zero byte files from NPM (#1708)

MetaMask · Aug 30, 2023 · 690d621 · 690d621
1 parent 094bcca
commit 690d621
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/snaps-controllers/src/snaps/location/npm.test.ts b/packages/snaps-controllers/src/snaps/location/npm.test.ts
@@ -66,11 +66,11 @@ describe('NpmLocation', () => {
     const manifest = await location.manifest();
     const sourceCode = (
       await location.fetch(manifest.result.source.location.npm.filePath)
-    ).value.toString();
+    ).toString();
     assert(manifest.result.source.location.npm.iconPath);
     const svgIcon = (
       await location.fetch(manifest.result.source.location.npm.iconPath)
-    ).value.toString();
+    ).toString();
 
     expect(fetchMock).toHaveBeenCalledTimes(2);
     expect(fetchMock).toHaveBeenNthCalledWith(

diff --git a/packages/snaps-controllers/src/snaps/location/npm.ts b/packages/snaps-controllers/src/snaps/location/npm.ts
@@ -376,7 +376,7 @@ function createTarballStream(
       // The name is a path if the header type is "file".
       const path = headerName.replace(NPM_TARBALL_PATH_PREFIX, '');
       return entryStream.pipe(
-        concat((data) => {
+        concat({ encoding: 'uint8array' }, (data) => {
           try {
             totalSize += data.byteLength;
             // To prevent zip bombs, we set a safety limit for the total size of tarballs.