chore(devDeps): bump metro and react-native

[legobeat]

Description

Update react-native and metro to receive patches.

• Update metro from 0.73 to 0.76
• Migrate from metro-config to @react-native/metro-config
• Update react-native from 0.71.15 to 0.72.14
  • Port patch
  • Remove hermes patch
• Bump and unpin @react-native-community/ packages
• Update @react-native-community/netinfo from 6.0.0 to ^9.5.0
  • Changelog
  • Release notes
  • v10 breaking change:

    netinfo now requires AbortController

• Update @react-native-masked-view/masked-view
  • Release notes
• Upgrade to Gradle version 8.0.1 and Android SDK 33

React Native Upgrade
Android SDK Update

Related issues

• Fixes: https://github.com/MetaMask/mobile-planning/issues/1262
• feat: upgrade react-native-webview #7759

Manual testing steps

Node environment must be 18.18.2
Supports Java version 17.0.10

1. Check out branch
2. Run yarn setup
3. Run yarn watch
4. Run yarn start:ios - wait for app to build on iOS simulator
5. Run yarn start:android - wait for app to build Android emulator

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@babel/[email protected], npm/@react-native-community/[email protected], npm/@react-native/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

[leotm]

i did a brief check of reactnative.dev/docs/0.71/environment-setup vs reactnative.dev/docs/0.72/environment-setup

couldn't spot anything we need to update in our docs, but may have missed something cc @MetaMask/mobile-platform

nb: JDK 17 is required in RN v0.73+
nb: Android 14 (UpsideDownCake) SDK required in RN v0.73+

nb: Node 18+ required in RN v0.73+ (we're ahead on Node 20)

nb: babel.config.js: metro-react-native-babel-preset -> @react-native/babel-preset in RN v0.73+

nb: RN new experimental debugger preview RN v0.73+ to replace Flipper

[leotm]

lgtm ^ thanks for reviewing with me @tommasini

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 067ba31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ba40a2d-19b9-4a2b-befd-3727477dd38d

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[metamaskbot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 067ba31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ba40a2d-19b9-4a2b-befd-3727477dd38d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

LGTM

[Cal-L]

Disabled CLA since Dan is OOO

[legobeat]

Related:

• Porting of this patch to upstream package in chore: bump android minSdkVersion from 19 to 21; target from 22 to 33 react-native-aes-crypto-forked#6
• Addressing insecure git-dependency usage in fix(deps): replace react-native-aes-crypto-forked with react-native-aes-crypto #9540

[legobeat]

This android/build.gradle.orig and below android/build.gradle.rej seem to be leftover from unsuccessful previous patch attempt. Addressed in #9540.

[legobeat]

Will there be a corresponding update in https://github.com/MetaMask/react-native-payments to obviate the need to keep patching this package?

[legobeat]

Issue in @metamask/rpc-errors: MetaMask/rpc-errors#131

It does seem like a general issue to pass a potentially cyclic stack as "serialized" and that it would make sense for @metamask/rpc-errors to do some form of cycle-safe serialization of the stack - stop after recursing N levels for example?