fix(3598): Strengthen the check for fallback network switching in the…

[EtherWizard33]

Strengthen the check for fallback network switching in the…… scenario where user unchecked the active chain.

Description

• GIVEN the dapp found itself on an unpermitted chain after the global chain was switched to a chain it had not granted permission to
• WHEN the user was added the permission to a different network by clicking Update button
• THEN there was a switch to the next permitted chain, before he actually selected the one he wanted from the permitted chains list.

Expected result, that chain change was unecessary, it should just wait for the user to select the chain from his permitted network. This is now fixed.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6484062
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54faf805-5e49-42a3-8ec0-5c611de01a74

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[EtherWizard33]

this PR is now cherry picked into another that was merged