Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable flaky tests on incoming-transactions.spec #12663

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Dec 12, 2024

Description

Disable flaky tests.

Related issues

Fixes: #12666

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

https://consensys.slack.com/archives/C02U025CVU4/p1734015329502949?thread_ts=1733944216.093729&cid=C02U025CVU4

https://app.bitrise.io/build/60766eba-3b3c-4b91-b1ea-7e78fa7cd881?tab=tests

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review December 12, 2024 18:05
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner December 12, 2024 18:05
Copy link

sonarcloud bot commented Dec 12, 2024

@chrisleewilcox chrisleewilcox added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 12, 2024
@chrisleewilcox chrisleewilcox changed the title fix: xit flaky tests on incoming-transactions.spec fix: disable flaky tests on incoming-transactions.spec Dec 12, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4eb5d34
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14aeb3ca-0f03-4f7a-af9f-4ac449d9a25d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 48adca9 Dec 12, 2024
46 of 53 checks passed
@chrisleewilcox chrisleewilcox deleted the e2e/xit-flaky-incoming-transactions branch December 12, 2024 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-7.38.1 Issue or pull request that will be included in release 7.38.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e2e-test No QA Needed Apply this label when your PR does not need any QA effort. release-7.38.1 Issue or pull request that will be included in release 7.38.1 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: disable incoming-transaction.spec flaky tests
3 participants