Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix token details navigation #12659

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Dec 12, 2024

Description

PR to fix app crash when user navigates to token details page.

Related issues

Fixes: #12660

Manual testing steps

  1. Click on any asset in your wallet
  2. Click on options (3 dots) top right
  3. Click on Token Details
  4. You should see token details without an app crash

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-12.at.15.56.56.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Dec 12, 2024

@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 32e4932
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d17065ab-ac6d-4a4e-89a7-1f309b0d8a28

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri marked this pull request as ready for review December 12, 2024 14:55
@sahar-fehri sahar-fehri requested a review from a team as a code owner December 12, 2024 14:55
@salimtb salimtb added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Dec 12, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 7e52ed6 Dec 12, 2024
48 of 53 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-token-details-navigation branch December 12, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App error when navigating to token details page
3 participants