Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poll only popular network #12658

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Dec 12, 2024

Description

To reduce the impact of showing assets across all networks, which can be unbounded, this PR scopes the portfolio view to the 9 popular networks built into metamask.

Related issues

Fixes: MetaMask/metamask-extension#29055

Manual testing steps

  1. On popular networks:
  • The token filter should allow switching between popular networks and current network
  • The filter should work as described
  • RPC requests in the background should only hit the popular networks
  1. On other networks
  • The token filter should become disabled and scoped to the current network
  • RPC requests in the background should only hit the current network

Screenshots/Recordings

Before

After

account-trcker.mov
currencyRate.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/fix-poll-only-popular-network branch from 36fe69c to 6f4ff39 Compare December 12, 2024 13:06
@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Dec 12, 2024
@salimtb salimtb added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Dec 12, 2024
@salimtb salimtb marked this pull request as ready for review December 12, 2024 14:45
@salimtb salimtb requested review from a team as code owners December 12, 2024 14:45
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f22b797
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3ee9b07-8f0f-45a1-8152-3e0875e14a1d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini
Copy link
Contributor

Can we have a recording of what changed?

@salimtb salimtb requested a review from a team as a code owner December 12, 2024 19:14
@salimtb salimtb requested a review from bergeron December 12, 2024 19:20
@salimtb salimtb marked this pull request as draft December 12, 2024 21:38
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@salimtb salimtb marked this pull request as ready for review December 13, 2024 13:08
Copy link
Contributor

github-actions bot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a4c25ef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/198b70b8-d46f-495a-b703-cf67f620aec5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb requested a review from bergeron December 13, 2024 13:11
@bergeron

This comment was marked as resolved.

@salimtb
Copy link
Contributor Author

salimtb commented Dec 13, 2024

One bug I notice.

  • Start on a popular network
  • With the filter set to 'current network'
  • Switch to a non-popular network
  • Switch back to the popular network

It keeps showing tokens from the non-popular network.

Screen.Recording.2024-12-13.at.9.54.43.AM.mov

@bergeron fixed 3adb9de

@bergeron

This comment was marked as resolved.

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bcad469
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/497f2346-4e3b-42f9-8b6a-7a51036bd038

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb
Copy link
Contributor Author

salimtb commented Dec 13, 2024

Now when switching networks while the filter is on 'current network', the tokens do not update to the new network.

Screen.Recording.2024-12-13.at.12.11.36.PM.mov

@bergeron bug fixed + flaky e2e test addressed , i should have a green build now

Copy link

sonarcloud bot commented Dec 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

[Bug]: Infinite Load after upgrade to 12.9.0
5 participants