Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-884 add more mobile pooled staking events #12651

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Dec 11, 2024

Description

This PR adds more events related to the pooled-staking flows.

Events Added

Stake Flow

  • Stake Cancel Clicked
  • Stake Gas Cost Impact Warning Triggered
  • Stake Gas Cost Impact Cancel Clicked,
  • Stake Gas Cost Impact Proceeded Clicked
  • Stake Confirmation Back Clicked
  • Stake Transaction Initiated
  • Stake Transaction Approved
  • Stake Transaction Rejected
  • Stake Transaction Confirmed
  • Stake Transaction Failed
  • Stake Transaction Submitted

Unstake Flow

  • Unstake Cancel Clicked
  • Unstake Confirmation Back Clicked
  • Unstake Transaction Initiated
  • Unstake Transaction Approved
  • Unstake Transaction Rejected
  • Unstake Transaction Confirmed
  • Unstake Transaction Failed
  • Unstake Transaction Submitted

Misc

  • VISITED_ETH_OVERVIEW_WITH_STAKED_POSITIONS

Related issues

Fixes: STAKE-884: Add more mobile pooled staking events

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 58.69%. Comparing base (da4021c) to head (8a9d08e).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...tionFooter/FooterButtonGroup/FooterButtonGroup.tsx 56.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12651   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files        1847     1850    +3     
  Lines       41629    41704   +75     
  Branches     5370     5386   +16     
=======================================
+ Hits        24433    24479   +46     
- Misses      15528    15547   +19     
- Partials     1668     1678   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matt561 Matt561 marked this pull request as ready for review December 12, 2024 18:20
@Matt561 Matt561 requested review from a team as code owners December 12, 2024 18:20
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but overall LGTM! Nicely done!

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d489b7e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d59fbc25-93f9-4241-a6b3-c6e816fb0b4c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3dd0def
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b5a708b0-1863-411f-8020-3bc18abcfd31

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Dec 13, 2024

@Matt561 Matt561 enabled auto-merge December 13, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

4 participants