-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-884 add more mobile pooled staking events #12651
base: main
Are you sure you want to change the base?
feat: STAKE-884 add more mobile pooled staking events #12651
Conversation
… stake and unstake confirmation views
…ated events on stake and unstake confirmation screens
…ked, and gas-cost-impact-proceeded-clicked events
…back-clicked events
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12651 +/- ##
=======================================
Coverage 58.69% 58.69%
=======================================
Files 1847 1850 +3
Lines 41629 41704 +75
Branches 5370 5386 +16
=======================================
+ Hits 24433 24479 +46
- Misses 15528 15547 +19
- Partials 1668 1678 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but overall LGTM! Nicely done!
app/components/UI/Stake/Views/StakeConfirmationView/StakeConfirmationView.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Bitrise❌❌❌ Commit hash: d489b7e Note
Tip
|
Bitrise❌❌❌ Commit hash: 3dd0def Note
Tip
|
Quality Gate passedIssues Measures |
Description
This PR adds more events related to the pooled-staking flows.
Events Added
Stake Flow
Stake Cancel Clicked
Stake Gas Cost Impact Warning Triggered
Stake Gas Cost Impact Cancel Clicked
,Stake Gas Cost Impact Proceeded Clicked
Stake Confirmation Back Clicked
Stake Transaction Initiated
Stake Transaction Approved
Stake Transaction Rejected
Stake Transaction Confirmed
Stake Transaction Failed
Stake Transaction Submitted
Unstake Flow
Unstake Cancel Clicked
Unstake Confirmation Back Clicked
Unstake Transaction Initiated
Unstake Transaction Approved
Unstake Transaction Rejected
Unstake Transaction Confirmed
Unstake Transaction Failed
Unstake Transaction Submitted
Misc
VISITED_ETH_OVERVIEW_WITH_STAKED_POSITIONS
Related issues
Fixes: STAKE-884: Add more mobile pooled staking events
Pre-merge author checklist
Pre-merge reviewer checklist