-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Chore/12628 create navigation provider #12649
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: e923754 Note
Tip
|
…/12628-create-navigation-gate
Bitrise❌❌❌ Commit hash: b466761 Note
Tip
|
Bitrise❌❌❌ Commit hash: 64c2bcb Note
Tip
|
Quality Gate passedIssues Measures |
Description
This PR cleans up the NavigationService and moves the navigation provider further up in the app stack. This ensures that the provider's children has access to the navigation object. This should reduce the number of cases where navigation is accessed before the navigation provider is ready. In theory, this should eliminate the navigation issue WRT WalletConnect service altogether - #12628. The metric to measure this improvement is looking at the reduction of this event - https://metamask.sentry.io/issues/4909236583/?environment=production&project=2299799&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20%22navigation%22&referrer=issue-stream&sort=date&statsPeriod=90d&stream_index=0
Related issues
Fixes: #12628
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist