Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update bug template to include feature branches #12623

Merged
merged 2 commits into from
Dec 10, 2024
Merged

chore: update bug template to include feature branches #12623

merged 2 commits into from
Dec 10, 2024
+19 −7

Conversation

jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Dec 10, 2024 •
edited
Loading

Description

Github bug template updated to include feature branches as a development stage

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jvbriones jvbriones added the team-qa QA team label Dec 10, 2024
@jvbriones jvbriones requested a review from a team as a code owner December 10, 2024 13:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jvbriones
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jvbriones jvbriones added No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. labels Dec 10, 2024
sethkfman
sethkfman approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvbriones jvbriones enabled auto-merge December 10, 2024 16:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jvbriones jvbriones added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 0f46383 Dec 10, 2024
36 checks passed
@jvbriones jvbriones deleted the chore-bugs-template-update branch December 10, 2024 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@gauthierpetetin gauthierpetetin gauthierpetetin approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-qa QA team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvbriones @gauthierpetetin @sethkfman @metamaskbot