Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide the smart transaction status page if we return a txHash asap #12622

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Dec 10, 2024

Description

We want to hide the smart transaction status page if we return a txHash asap, which we want to do always going forward. Once we verify it works as expected and no fallback is needed, we can remove the STX status page from the codebase.

Related issues

Fixes: TXL-538

Manual testing steps

  1. Be on Ethereum Mainnet + smart transactions enabled in Advanced Settings
  2. Do a transaction
  3. You will not see the STX status page, only a Toast notification as we do for regular (non-STX) transactions

Screenshots/Recordings

Smart transaction is submitted:
image

Smart transaction is completed:
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Dec 10, 2024
@dan437 dan437 requested a review from a team as a code owner December 10, 2024 12:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e6762be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5fcefc4-3b3e-4d34-951e-8c8246670c62

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dan437 dan437 force-pushed the hide-stx-status-page branch from e6762be to cbee4dd Compare December 11, 2024 10:48
@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cbee4dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4f6bc0c2-53c0-4391-a132-9aa71f91e6fe

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Dec 11, 2024

@dan437 dan437 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 0b676de Dec 11, 2024
40 checks passed
@dan437 dan437 deleted the hide-stx-status-page branch December 11, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants