Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix network selector bug #12605

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Dec 8, 2024

Description

PR to fix network selector bug

Related issues

Fixes: #12423

Manual testing steps

  1. Go to the network selector
  2. Go to search input and search for a network
  3. the input should not be hidden

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 8, 2024
@salimtb salimtb force-pushed the salim/fix-network-selector-bug branch from cbff284 to 033b8bf Compare December 8, 2024 11:26
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 8, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: feaac4b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d9f4a61-05db-4098-9a8e-cf9bb896386d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb force-pushed the salim/fix-network-selector-bug branch from 2b1aba7 to 5e02ae0 Compare December 9, 2024 07:04
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5e02ae0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31ac42df-240a-44f1-99e3-97cca54a4924

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7901760
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eba94073-2100-47b9-b589-a00518d07914

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b9d4169
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cfcb9deb-d5fe-4177-8bb4-1583d76e7459

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 639de84
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/afbd8968-309d-4574-832c-22234b416ba7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 9, 2024
@salimtb salimtb marked this pull request as ready for review December 9, 2024 14:33
@salimtb salimtb requested a review from a team as a code owner December 9, 2024 14:33
Copy link

sonarcloud bot commented Dec 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Network Search bar disappears when search a network
2 participants