Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MultichainBalanceController #12599

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Dec 6, 2024

Description

Builds off of the work done in this PR.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Dec 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 0 B

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@owencraston owencraston force-pushed the feat/multichain-balance-controller branch 4 times, most recently from a99e4bf to 31f3fec Compare December 12, 2024 01:43
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@owencraston owencraston force-pushed the feat/multichain-balance-controller branch from 31f3fec to d17ffc9 Compare December 13, 2024 04:41
@owencraston owencraston force-pushed the feat/multichain-balance-controller branch from d17ffc9 to 373bf9e Compare December 13, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants