Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add resolution for express to fix failing audit on path-to-regexp #12591

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Dec 6, 2024

Description

Adds resolution for express (which updates path-to-regexp to 0.1.12)

As the affected version of path-to-regexp is only on the express module. And [email protected] updates path-to-regexp to 0.1.12, I've added a resolution to update express.

Express 4.21.2 changelog

NOTE - once mockttp releases > 3.15.5, it should upgrade express which should upgrade path-to-regexp that will also resolve this issue. Once it releases, then we can remove this resolution.

Related issues

Fixes: GHSA-rhx6-c78j-4q9w

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners December 6, 2024 10:08
Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Dec 6, 2024
Copy link

socket-security bot commented Dec 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, network +3 259 kB jonchurch
npm/[email protected] None 0 6.6 kB blakeembrey, defunctzombie, dougwilson, ...2 more

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the fix/failing-audit-mockttp-express-package branch from d2f4a81 to 223f016 Compare December 6, 2024 10:15
@Prithpal-Sooriya Prithpal-Sooriya changed the title fix: add resolution for mockttp/express/path-to-regexp fix: add resolution for express to fix failing audit on path-to-regexp Dec 6, 2024
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 223f016
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a3295eb-d14a-456d-89bc-f8349a45cf98

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

sonarcloud bot commented Dec 6, 2024

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can accept the security bot advisory
This was the commit in express: expressjs/express@2e0fb64

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit dc52797 Dec 6, 2024
45 of 48 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/failing-audit-mockttp-express-package branch December 6, 2024 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants