-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @metamask/{preferences,assets}-controllers
#12579
chore: bump @metamask/{preferences,assets}-controllers
#12579
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise🔄🔄🔄 Commit hash: 94b67d0 Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bitrise✅✅✅ Commit hash: 3f54694 Note
|
@tommasini We are using But I have no problem waiting for the other one to be merged first. |
The keyring controller update is now merged, so perhaps we can update this branch to resolve the peer dependency warning before merging |
Could you bump the assets-controllers package to v45 as well? That would resolve the last peer dependency warning introduced by this change (and it would resolve two existing peer dependency warnings). There are no breaking changes in that bump except these peer dependency changes. |
@metamask/preferences-controller
to 15.0.1
@metamask/{preferences-controller,assets-controllers}
Bitrise🔄🔄🔄 Commit hash: d2d1b22 Note
|
Bitrise✅✅✅ Commit hash: 896a2e6 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
@metamask/{preferences-controller,assets-controllers}
@metamask/{preferences,assets}-controllers
Description
This PR bumps:
@metamask/preferences-controller
to15.0.1
@metamask/assets-controllers
to45.1.1
Related issues
Fixes: #12382, #12380
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist