Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/{preferences,assets}-controllers #12579

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Dec 5, 2024

Description

This PR bumps:

  • @metamask/preferences-controller to 15.0.1
  • @metamask/assets-controllers to 45.1.1

Related issues

Fixes: #12382, #12380

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s added team-wallet-framework Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 5, 2024
@cryptodev-2s cryptodev-2s self-assigned this Dec 5, 2024
@cryptodev-2s cryptodev-2s requested review from a team as code owners December 5, 2024 17:41
Copy link
Contributor

github-actions bot commented Dec 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 94b67d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be78ec4f-7815-456f-93ee-8331a9e09077

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

socket-security bot commented Dec 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +2 2.38 MB metamaskbot
npm/@metamask/[email protected] None 0 105 kB metamaskbot
npm/@metamask/[email protected] None 0 140 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should we merge keyring controller to v19 first?

"@metamask/keyring-controller": "^18.0.0",

changelog: https://github.com/MetaMask/core/blob/%40metamask/preferences-controller%4015.0.1/packages/preferences-controller/CHANGELOG.md

It seems almost ready: #12555

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3f54694
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b539bb36-bd06-46ad-82e2-0987d5b9c70c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s
Copy link
Contributor Author

cryptodev-2s commented Dec 5, 2024

Actually, should we merge keyring controller to v19 first?

"@metamask/keyring-controller": "^18.0.0",

changelog: https://github.com/MetaMask/core/blob/%40metamask/preferences-controller%4015.0.1/packages/preferences-controller/CHANGELOG.md

It seems almost ready: #12555

@tommasini We are using @metamask/keyring-controller within @metamask/preferences-controller at this location: https://github.com/MetaMask/core/blob/main/packages/preferences-controller/src/PreferencesController.ts#L272. In this context, we only listen to keyring state changes. Reviewing the CHANGELOG for @metamask/keyring-controller from version 18 to 19, there are no state changes or updates that would affect this version bump.

But I have no problem waiting for the other one to be merged first.

@Gudahtt
Copy link
Member

Gudahtt commented Dec 6, 2024

The keyring controller update is now merged, so perhaps we can update this branch to resolve the peer dependency warning before merging

@Gudahtt
Copy link
Member

Gudahtt commented Dec 6, 2024

Could you bump the assets-controllers package to v45 as well? That would resolve the last peer dependency warning introduced by this change (and it would resolve two existing peer dependency warnings). There are no breaking changes in that bump except these peer dependency changes.

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/preferences-controller to 15.0.1 chore: bump @metamask/{preferences-controller,assets-controllers} Dec 6, 2024
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d2d1b22
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ee1b5ee-e1e1-4556-9f15-6d60e8e5656c

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

package.json Outdated Show resolved Hide resolved
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 6, 2024
@cryptodev-2s cryptodev-2s dismissed stale reviews from Gudahtt and tommasini via 896a2e6 December 6, 2024 22:14
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 896a2e6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a54916bf-c4cb-4e1d-8d02-18f42f26be81

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s requested review from tommasini and removed request for tommasini December 6, 2024 23:00
Copy link

sonarcloud bot commented Dec 7, 2024

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/{preferences-controller,assets-controllers} chore: bump @metamask/{preferences,assets}-controllers Dec 9, 2024
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 3dcd114 Dec 9, 2024
69 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-preferences-controller-15.0.1 branch December 9, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update metamask/preferences-controller to version 15.0.0
5 participants