Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(12550): adding popular network no longer switches network filter #12578

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

vinnyhoward
Copy link
Contributor

Description

Fixed an issue where adding a popular network switches the network filter. For example if the user is on "All Networks" and they add a popular network such as Avalanche, the network switcher reverts to that network, instead it should stay at "All Networks"

Related issues

Fixes: #12550

Manual testing steps

  1. Click on "All Networks" filter
  2. Click on the network tab, then add a popular network such as Avalanche
  3. Make sure the network filter stays at "All Networks"

Screenshots/Recordings

NA

Before

See video of before in issue

After

before.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added team-assets team-wallet-ux portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Dec 5, 2024
@vinnyhoward vinnyhoward requested review from a team as code owners December 5, 2024 17:39
Copy link
Contributor

github-actions bot commented Dec 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Dec 5, 2024
Copy link

sonarcloud bot commented Dec 5, 2024

@vinnyhoward vinnyhoward merged commit 613a431 into feat-multichain-list Dec 5, 2024
45 checks passed
@vinnyhoward vinnyhoward deleted the fix-12550-network-switcher branch December 5, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run portfolio-view Used for PRs and issues related to Q4 2024 portfolio view team-assets team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant