Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(12527): sdk connection with unknown url causes a bug #12566

Merged

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Dec 5, 2024

Description

When the user uses SDK to connect to a dapp which does not provide a URL, unknown URL, this causes a bug.

Related issues

Fixes: #12527

Manual testing steps

  1. Go to https://unknown-url.vercel.app/
  2. Tap connect
  3. choose Metamask Wallet, or scan the QR Code with the MetaMask QR Code reader

Screenshots/Recordings

Screenshot 2024-04-18s at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6b43eb0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/409baffe-b7a1-4bcc-923c-f9fee4bc8c1d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 changed the title Fix 12527 fallback to dapp without url crashes the app 2 fix(12527): sdk connection with unknown url causes a bug Dec 5, 2024
@EtherWizard33 EtherWizard33 marked this pull request as ready for review December 5, 2024 00:26
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner December 5, 2024 00:26
Copy link

sonarcloud bot commented Dec 5, 2024

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 43ae0a1 Dec 5, 2024
36 checks passed
@EtherWizard33 EtherWizard33 deleted the fix-12527-fallback-to-dapp-without-URL-crashes-the-app-2 branch December 5, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fallback to dapp without URL crashes the app
3 participants