Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cicd e2e hardening #12563

Merged
merged 2 commits into from
Dec 5, 2024
Merged

chore: cicd e2e hardening #12563

merged 2 commits into from
Dec 5, 2024

Conversation

jake-perkins
Copy link
Contributor

@jake-perkins jake-perkins commented Dec 4, 2024

Description

Handle scenarios where MQ and PR context is different when executing in the merge queue context

Related issues

Fixes:
The E2E Bitrise status from not being in a completed state when in the MQ

Manual testing steps

Tested in alternate repo replicating setup
https://github.com/MetaMask/temp-gh-action-testing/actions/runs/12169779361/job/33943429158

Screenshots/Recordings

Before

N/A CICD Only

After

N/A CICD Only

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jake-perkins jake-perkins requested a review from a team as a code owner December 4, 2024 23:01
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Dec 4, 2024
@jake-perkins jake-perkins added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 66adda5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1ca83a57-106a-4781-90e8-20733befcbc8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jake-perkins jake-perkins added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 4, 2024
Copy link

sonarcloud bot commented Dec 4, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jake-perkins jake-perkins added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 16f3df4 Dec 5, 2024
43 of 44 checks passed
@jake-perkins jake-perkins deleted the e2e-hardening branch December 5, 2024 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants