Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move AssetPollingProvider from Root to Nav/Main/index.js #12562

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Dec 4, 2024

Description

Picks AssetPollingProvider diff from https://github.com/MetaMask/metamask-mobile/pull/12538/files bug fix to isolate changes.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish requested review from bergeron and Cal-L December 4, 2024 22:57
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 030ea0c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2ace71a9-3b16-484c-9d7b-89f4828d468c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Dec 4, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gambinish gambinish changed the title fix: Move AssetPollingProvider from Root to Nav/Main/index.js fix: Move AssetPollingProvider from Root to Nav/Main/index.js Dec 4, 2024
@gambinish gambinish marked this pull request as ready for review December 4, 2024 23:24
@gambinish gambinish requested a review from a team as a code owner December 4, 2024 23:24
@gambinish gambinish added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit a93ef10 Dec 5, 2024
46 of 50 checks passed
@gambinish gambinish deleted the fix/move-asset-provider-to-nav-index branch December 5, 2024 00:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants