Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable ledger clear signing feature #12537

Merged
merged 10 commits into from
Dec 12, 2024
Merged

feat: enable ledger clear signing feature #12537

merged 10 commits into from
Dec 12, 2024
+7 −6

Conversation

dawnseeker8
Copy link
Contributor

Description

This PR enable the clear signing feature in metamask mobile.
Please refer to this feature requests for detail: https://github.com/MetaMask/accounts-planning/issues/544

Related issues

Fixes:

Manual testing steps

Test the clear signing using this dapp provided by ledger team:
https://clear-signing-tester.vercel.app/
When test in EIP712 sign message, please use polygon mainnet or ethereum mainnet.
sign transcation can use linea testnet.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 changed the title Feat/ledger clean signing feat: enable ledger clean signing feature Dec 4, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Dec 4, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 316 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@dawnseeker8 dawnseeker8 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 762f40b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e2b8703-b7de-4591-bcb6-3d4cd968a912

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 26ad4d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5b6486d0-867a-47ee-836c-e598564df3c0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dawnseeker8 dawnseeker8 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 6, 2024
@Akaryatrh Akaryatrh force-pushed the feat/ledger-clean-signing branch 2 times, most recently from 7a6a374 to a392258 Compare December 9, 2024 17:06
@Akaryatrh Akaryatrh marked this pull request as ready for review December 9, 2024 17:23
@Akaryatrh Akaryatrh requested review from a team as code owners December 9, 2024 17:23
@Akaryatrh Akaryatrh force-pushed the feat/ledger-clean-signing branch 3 times, most recently from dfa7145 to cd2de1e Compare December 9, 2024 18:05
@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5986b12
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf5ad14d-d034-4b47-8875-37a1cef8a9ed

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 778d629
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/583c307a-fe97-4efa-a8bc-b36dce5cf76d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d424f04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cbec4d45-2020-4760-9e80-589d6aca43c9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Akaryatrh Akaryatrh force-pushed the feat/ledger-clean-signing branch from d424f04 to e56316e Compare December 10, 2024 10:39
@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e56316e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b34df0cb-d916-4a79-b476-c71ececdef5e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Akaryatrh Akaryatrh added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 64686f3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/638c29e7-908b-4f23-81ae-6c75a47ebf0f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Akaryatrh Akaryatrh added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@vivek-consensys vivek-consensys added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 11, 2024
@vivek-consensys
Copy link
Contributor

Tested on iOS and Android and working as expected using the dApp
Screen recordings include:

  • Sign EIP-712 transaction using clear signing on Linea Sepolia
  • Send (native) transaction on Polygon Mainnet

Private Zenhub Video

Private Zenhub Video

@vivek-consensys vivek-consensys added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Dec 11, 2024
@Akaryatrh Akaryatrh added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@vivek-consensys vivek-consensys added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit c1c2e79 Dec 12, 2024
47 of 52 checks passed
@vivek-consensys vivek-consensys deleted the feat/ledger-clean-signing branch December 12, 2024 04:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-hardware-wallets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dawnseeker8 @vivek-consensys @gantunesr @tommasini @Akaryatrh @metamaskbot