Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: activate portfolio view #12507

Merged
merged 127 commits into from
Dec 11, 2024
Merged

feat: activate portfolio view #12507

merged 127 commits into from
Dec 11, 2024
+495 −7

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Dec 2, 2024 •
edited by sahar-fehri
Loading

Description

This PR turns on the Portfolio view feature flag.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vinnyhoward and others added 30 commits November 25, 2024 12:43
@vinnyhoward
feat: cherry picking from multichain list experimental branch
3a51189
@vinnyhoward
Merge branch 'main' of github.com:MetaMask/metamask-mobile into feat-…
9857f4c 
…multichain-list
@salimtb
feat: add multichain tokens autodetection feature
9354e71
@salimtb
fix: fix hide token
b55ee59
@salimtb
fix: fix linter
a3fb53a
@salimtb
fix: add unit test
25e4d9f
@salimtb
fix: fix hide token case
bb938c9
@vinnyhoward
Merge branch 'main' of github.com:MetaMask/metamask-mobile into feat-…
55b163e 
…multichain-list
@salimtb
fix: add unit tests
bd8fcc8
@salimtb
fix: clean up
c22734c
@vinnyhoward
fix: fixed tests for feature flag off and all except one for feature …
febb235 
…flag on
@vinnyhoward
fix: linting issues
b1205f5
@vinnyhoward
fix: updating tests to increase coverage
0bbc069
@vinnyhoward
merged token detection branch and updated tests
60a2121
@salimtb
Merge branch 'main' into salim/multichain-detect-tokens-feat
5b8756b
@salimtb
Merge branch 'salim/multichain-detect-tokens-feat' into feat-multicha…
b6ea346 
…in-list
@salimtb
fix: fix linter
e7e4217
@salimtb
fix: fix hide token
7fca372
@salimtb
fix: increase test coverage
576d910
@salimtb
fix: increase test coverage
5f81279
@salimtb
fix: add test for staking chain hook
f0db4e5
@salimtb
fix: increase test coverage
32ce6a0
@salimtb
fix: increase test coverage
83dfe6c
@salimtb
fix: fix snapshot
cc24739
@salimtb
fix: increase coverage
5f57e94
@salimtb
fix: increase test coverage
16e1d24
@salimtb
fix: increase test coverage
c15d95e
@salimtb
fix: fix block explorer
3d5cf83
@salimtb
fix: fix bugs
767f1c2
@salimtb
fix: clean up
71d004a
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 10, 2024
@sahar-fehri sahar-fehri removed request for a team December 10, 2024 20:30
Cal-L
Cal-L reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

app/util/networks/index.js Outdated Show resolved Hide resolved
Cal-L
Cal-L previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: be6c827
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3191a13d-4b83-4fe3-9f00-1bb65e417e69

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinnyhoward
vinnyhoward previously approved these changes Dec 10, 2024
View reviewed changes
@salimtb salimtb dismissed stale reviews from vinnyhoward and Cal-L via 4d5d4a9 December 10, 2024 20:51
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4d5d4a9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06b3c498-2464-4e35-ba43-dcedc36d47a0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vinnyhoward vinnyhoward added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 259faa3 Dec 11, 2024
36 checks passed
@vinnyhoward vinnyhoward deleted the salim/PORTFOLIO_VIEW-on branch December 11, 2024 02:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gambinish gambinish gambinish left review comments

@sahar-fehri sahar-fehri sahar-fehri left review comments

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@Cal-L Cal-L Cal-L approved these changes

@nickewansmith nickewansmith nickewansmith approved these changes

Assignees
No one assigned
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@salimtb @nickewansmith @Cal-L @sahar-fehri @vinnyhoward @gambinish @metamaskbot