Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add translations for notification feature - 1/7 #10299

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR adds all translations needed for Notifications UI. No UI change is represented in this PR.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform team-notifications Notifications team labels Jul 14, 2024
@Jonathansoufer Jonathansoufer self-assigned this Jul 14, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner July 14, 2024 16:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jul 14, 2024
Copy link

sonarcloud bot commented Jul 14, 2024

@Jonathansoufer Jonathansoufer changed the title chore: add translations for notification feature - 3/7 chore: add translations for notification feature - 1/7 Jul 15, 2024
@Jonathansoufer Jonathansoufer merged commit a18e2f7 into main Jul 15, 2024
51 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/add-notifications-translations branch July 15, 2024 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants