Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix TS errors for some component library files #10275

Closed
wants to merge 3 commits into from

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented Jul 10, 2024

Description

The aim of this chore is to

Related issues

Partially fixes: #10200

Manual testing steps

  1. yarn lint should yield no new or unexpected TypeScript errors

Screenshots/Recordings

n/a

Before

n/a

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kylanhurt kylanhurt added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c267b05
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/25da2876-c504-4d3b-a56b-efcf032b1c74

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@kylanhurt kylanhurt marked this pull request as ready for review July 10, 2024 00:32
@kylanhurt kylanhurt requested review from a team as code owners July 10, 2024 00:32
@kylanhurt kylanhurt marked this pull request as draft July 10, 2024 01:13
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.68%. Comparing base (ea14ef7) to head (e493422).
Report is 36 commits behind head on main.

Files Patch % Lines
...regatedPercentage/AggregatedPercentage.stories.tsx 0.00% 3 Missing ⚠️
...rice/PercentageChange/PercentageChange.stories.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10275      +/-   ##
==========================================
+ Coverage   49.50%   49.68%   +0.17%     
==========================================
  Files        1438     1451      +13     
  Lines       34674    34934     +260     
  Branches     3853     3961     +108     
==========================================
+ Hits        17166    17356     +190     
- Misses      16426    16468      +42     
- Partials     1082     1110      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const Template = (args) => <AggregatedPercentage {...args} />;
export default AggregatedPercentageStory;

interface AggregatedPercentageArgs {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible for you to add a .types file to the AggregatedPercentage folder with this interface so that it's reusable for the main component as well?

@brianacnguyen
Copy link
Contributor

Looking good so far. Haven't had a chance to look at these stories to confirm. Will do that tomorrow @kylanhurt

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, eval 0 3.92 MB szydlovsky

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Oct 10, 2024
Copy link
Contributor

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise stale Issues that have not had activity in the last 90 days team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Chore: Typescript type coverage component-library folder
3 participants