-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix TS errors for some component library files #10275
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: c267b05 Note
|
Quality Gate failedFailed conditions |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10275 +/- ##
==========================================
+ Coverage 49.50% 49.68% +0.17%
==========================================
Files 1438 1451 +13
Lines 34674 34934 +260
Branches 3853 3961 +108
==========================================
+ Hits 17166 17356 +190
- Misses 16426 16468 +42
- Partials 1082 1110 +28 ☔ View full report in Codecov by Sentry. |
const Template = (args) => <AggregatedPercentage {...args} />; | ||
export default AggregatedPercentageStory; | ||
|
||
interface AggregatedPercentageArgs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible for you to add a .types
file to the AggregatedPercentage folder with this interface so that it's reusable for the main component as well?
Looking good so far. Haven't had a chance to look at these stories to confirm. Will do that tomorrow @kylanhurt |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions. |
Description
The aim of this chore is to
Related issues
Partially fixes: #10200
Manual testing steps
yarn lint
should yield no new or unexpected TypeScript errorsScreenshots/Recordings
n/a
Before
n/a
After
Pre-merge author checklist
Pre-merge reviewer checklist