chore: reorder accounts in ETH_REQUESTACCOUNTS response to prioritize selectedAddress in the 'AndroidService'

[omridan159]

Description

Summary

This PR implements logic to reorder the accounts in the ETH_REQUESTACCOUNTS response, ensuring that the selected address appears first in the list. This update is part of the sendMessage method in the AndroidService class.

Changes

• Retrieve the selected address from the PreferencesController.
• Convert all account addresses in the response to lowercase.
• Check if the selected address is part of the connected addresses.
• Reorder the accounts list, placing the selected address at the beginning if it exists in the list.
• Update the message data with the reordered accounts list.

Why

Reordering the accounts list enhances user experience by making the selected address more prominent and easily accessible. This change ensures that the selected address is always the first in the list returned by the ETH_REQUESTACCOUNTS method.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[christopherferreira9]

Test cases:

• Resume session with Android SDK Dapp after killing MM
• Resume session with Android SDK Dapp after restarting the dapp
• Account sync

Skipping E2E since these changes are strict to the Android service that is currently not covered on E2E

[andreahaku]

LGTM