Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blockaid validations for deeplink transactions #10192

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 1, 2024

Description

Fix blockaid validations for deeplink transactions.

Related issues

Fixes: #9365

Manual testing steps

  1. Submit a malicious deeplink transaction on emulator
  2. Ensure that transaction error is visible

Screenshots/Recordings

Screenshot 2024-07-01 at 7 14 01 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Jul 1, 2024
@jpuri jpuri requested review from a team as code owners July 1, 2024 13:38
Copy link
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0555ae7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/114fd12d-9d90-4e81-87a6-02a42215df54

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Jul 1, 2024

@jpuri jpuri merged commit 3046046 into main Jul 2, 2024
43 of 44 checks passed
@jpuri jpuri deleted the blockaid_deeplink_fix branch July 2, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.27.1 Issue or pull request that will be included in release 7.27.1 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Malicious Deeplink transactions are not being flagged
4 participants