-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implementing Firebase messaging on iOS/Android #10184
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Bitrise❌❌❌ Commit hash: 51c53d0 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10184 +/- ##
==========================================
+ Coverage 49.50% 49.51% +0.01%
==========================================
Files 1438 1439 +1
Lines 34674 34707 +33
Branches 3853 3860 +7
==========================================
+ Hits 17166 17186 +20
- Misses 16426 16434 +8
- Partials 1082 1087 +5 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: 62e8dfb Note
|
Bitrise✅✅✅ Commit hash: 1eda810 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once this is in we can focus on the implementation. And using this for push notifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Co-authored-by: Cal Leung <[email protected]>
Co-authored-by: Cal Leung <[email protected]>
Co-authored-by: Cal Leung <[email protected]>
…k-mobile into feat/firebase-messaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last 2 comments
Co-authored-by: Cal Leung <[email protected]>
Co-authored-by: Cal Leung <[email protected]>
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 1685749 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For socket security, we can ignore the new packages from firebase
Description
This PR aims to handle ONLY the addition of Firebase related libraries to our codebase as well implements iOS and Android specific setup to enable Push Notifications FCM on MetaMask Mobile. No changes on consuming Push Notifications will take place on THIS PR since we're breaking this implementation down. No visual changes are introduced as well nor ways to test it, since the video updated is just to increase the understanding of what the changes will empower.
Documentation used for implementing it, here
ATTENTION: Flipper DOESN'T work with Firebase, so we endorse using Charles Proxy instead.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-06-25.at.20.08.51.mov
Pre-merge author checklist
Pre-merge reviewer checklist