-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: browser address bar #10156
fix: browser address bar #10156
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
justifyContent: 'center', | ||
height: '100%', | ||
backgroundColor: '#000000dd', | ||
zIndex: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, this view blocks the interaction on everything that's under it
Curious question, I see that there is no opacity at this view, is this background color that gives that transparent look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! This is just a rough draft solution, but the last 2 digits of the hex code are the alpha for the background color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answer! Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to use one of the theme colors 👍 that inline hex color was for POC
Could you add recordings of android behaviour as well? |
Quality Gate failedFailed conditions |
Description
See more details here
Related issues
Fixes: #1519
Manual testing steps
Screenshots/Recordings
Before
After
pulse.mp4
Pre-merge author checklist
Pre-merge reviewer checklist