Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser address bar #10156

Closed
wants to merge 3 commits into from
Closed

fix: browser address bar #10156

wants to merge 3 commits into from

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Jun 27, 2024

Description

See more details here

Related issues

Fixes: #1519

Manual testing steps

  1. See related issue

Screenshots/Recordings

Before

After

pulse.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

justifyContent: 'center',
height: '100%',
backgroundColor: '#000000dd',
zIndex: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this view blocks the interaction on everything that's under it
Curious question, I see that there is no opacity at this view, is this background color that gives that transparent look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is just a rough draft solution, but the last 2 digits of the hex code are the alpha for the background color

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the answer! Great work!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to use one of the theme colors 👍 that inline hex color was for POC

@tommasini
Copy link
Contributor

Could you add recordings of android behaviour as well?

@cortisiko cortisiko changed the title fix: hotfix block UI on spoofing website & pulse prog indicator fix: browser address bar Jun 28, 2024
@frankvonhoven frankvonhoven added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 28, 2024
@frankvonhoven frankvonhoven marked this pull request as ready for review June 28, 2024 15:38
@frankvonhoven frankvonhoven requested a review from a team as a code owner June 28, 2024 15:38
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants