fix: sets data marketing to false in case of non-selection

[jonybur]

Description

Avoids showing the experience enhancer modal after onboarding.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2704

Manual testing steps

1. Onboard
2. User should not see experience enhancer after onboarding

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7c25a02
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2ccc935c-0ad8-43bb-8f94-354c2f8d967e

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.78%. Comparing base (4b9f31c) to head (c21ca73).
Report is 7 commits behind head on main.

Files	Patch %	Lines
app/components/UI/OptinMetrics/index.js	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10154      +/-   ##
==========================================
- Coverage   49.78%   49.78%   -0.01%     
==========================================
  Files        1437     1437              
  Lines       34762    34813      +51     
  Branches     3921     3928       +7     
==========================================
+ Hits        17307    17330      +23     
- Misses      16354    16381      +27     
- Partials     1101     1102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tommasini]

@jonybur can we include recordings on this video on what was tested?

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5da5f36
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8278c9bb-c21c-40cf-983b-366e3bd61b1f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
56.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[hesterbruikman]

Recording of following test scenario:

• Fresh onboard
• Marketing consent opt-in checkbox is shown:

Deny marketing consent during onboarding

Screen_Recording_20240726-191836_MetaMask-QA.mp4

Opt in to marketing consent during onboarding

Note that this video shows the checkbox as pre-checked. This is not the actual behavior; it's because I forgot to start recording and had already checked it

Screen_Recording_20240726-192103_MetaMask-QA.mp4

[NicolasMassart]

Looks good to me.