Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add increase decrease token percentage #10144

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 27, 2024

Description

This pull request introduces a new feature to the MetaMask mobile that enhances user experience by displaying the percentage increase or decrease for each token directly within the UI. This update aims to provide users with immediate visual feedback on the performance of their tokens, helping them make more informed decisions based on recent market trends.

core PR: MetaMask/core#4206
figma: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Wallet-Assets?node-id=1620-23897&t=EJSzfKoFvTJ5LuK0-0

Related issues

Fixes: #9635

Manual testing steps

  1. Go to the wallet view
  2. You should see the percentage of increase/decrease

Screenshots/Recordings

Before

Screenshot 2024-05-15 at 16 54 25

After

Screenshot 2024-05-15 at 16 39 31

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested review from a team as code owners June 27, 2024 14:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb mentioned this pull request Jun 27, 2024
7 tasks
@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 27, 2024
@salimtb salimtb force-pushed the feat-increase-decrease-percentage-tokens branch 2 times, most recently from 6b5f614 to fc9ecc5 Compare June 27, 2024 14:28
@salimtb salimtb marked this pull request as draft June 27, 2024 14:29
@salimtb salimtb force-pushed the feat-increase-decrease-percentage-tokens branch from fc9ecc5 to 39fa7aa Compare June 27, 2024 14:41
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 27, 2024
@salimtb salimtb force-pushed the feat-increase-decrease-percentage-tokens branch from 39fa7aa to c4f7118 Compare June 27, 2024 15:49
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 27, 2024
@salimtb salimtb marked this pull request as ready for review June 27, 2024 16:13
@salimtb salimtb force-pushed the feat-increase-decrease-percentage-tokens branch from c4f7118 to b5b9dbc Compare June 27, 2024 17:56
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 27, 2024
@salimtb salimtb force-pushed the feat-increase-decrease-percentage-tokens branch from b5b9dbc to f30265e Compare June 27, 2024 18:07
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 27, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jun 27, 2024
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 27, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jun 27, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f30265e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e09230f8-423b-448b-82cf-2d62e7f935eb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
cortisiko
cortisiko previously approved these changes Jul 2, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎬 🌮 🌮

@salimtb salimtb force-pushed the feat-increase-decrease-percentage-tokens branch from 8d87096 to b8c071b Compare July 2, 2024 21:21
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jul 2, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jul 2, 2024
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0a06061
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a658804b-93b5-47f4-9be0-588090ff0173

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 3, 2024
Copy link

sonarcloud bot commented Jul 3, 2024

Copy link
Contributor

github-actions bot commented Jul 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ed812b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/905546af-2441-4a24-89e4-a011046d04bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 3, 2024
@salimtb salimtb merged commit 0f40b8d into main Jul 3, 2024
41 of 44 checks passed
@salimtb salimtb deleted the feat-increase-decrease-percentage-tokens branch July 3, 2024 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@metamaskbot metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.27.1 Issue or pull request that will be included in release 7.27.1 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement increase decrease percentage
6 participants