Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on mobile #10139

Merged
merged 11 commits into from
Jul 12, 2024
Merged

feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on mobile #10139

merged 11 commits into from
Jul 12, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 27, 2024 •
edited
Loading

Description

Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2717

Manual testing steps

  1. Add networks zkSync, Berachain, Scroll and Metachain One to extension
  2. Submit a malicious transaction on test dapp
  3. Ensure it is reported as malicious

Screenshots/Recordings

Screenshot 2024-07-02 at 6 27 37 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 27, 2024
@jpuri jpuri changed the title feat: Add support of blockaid validations for more networks feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension Jun 28, 2024
@jpuri jpuri added the DO-NOT-MERGE Pull requests that should not be merged label Jun 28, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Jun 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/[email protected] network 0 3.34 MB blockaiduser
npm/@metamask/[email protected] Transitive: environment, filesystem, network, unsafe +46 8.86 MB metamaskbot

🚮 Removed packages: npm/@blockaid/[email protected], npm/@metamask/[email protected]

View full report↗︎

@jpuri jpuri marked this pull request as ready for review July 2, 2024 12:34
@jpuri jpuri requested review from a team as code owners July 2, 2024 12:34
@jpuri jpuri removed the DO-NOT-MERGE Pull requests that should not be merged label Jul 2, 2024
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 832b8b4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46255be2-a3a6-4f14-a116-3b31b9d8add9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri requested a review from a team as a code owner July 2, 2024 12:52
@jpuri jpuri force-pushed the blockaid_network_support branch from 7312b7b to 08092c5 Compare July 2, 2024 14:27
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ca7df7d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d6f82a6-8730-4e39-862b-a0a6232b28cf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pedronfigueiredo
pedronfigueiredo approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you might want to update the description and title to mobile instead of extension to avoid confusion.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 5, 2024
@tommasini
Copy link
Contributor

Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension
Hey @jpuri
You mean on mobile?

@jpuri jpuri merged commit 283d8f2 into main Jul 12, 2024
61 of 62 checks passed
@jpuri jpuri deleted the blockaid_network_support branch July 12, 2024 07:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 12, 2024
@chrisleewilcox chrisleewilcox changed the title feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on mobile Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees
No one assigned
Labels
release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jpuri @tommasini @pedronfigueiredo @matthewwalsh0 @metamaskbot