Skip to content

Commit

Permalink
chore: disable snaps feat from main temporarily (#10278)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR disable preinstalled-snaps from main build since no feature will
be using it at this point. The first feature relying on
preinstalled-snap (signing-snap) is notifications, which is not part of
the current release.

## **Related issues**

Fixes:

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Jonathansoufer authored Jul 10, 2024
1 parent b87c1f8 commit f7d8e61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion metro.transform.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const availableFeatures = new Set([
'beta',
]);

const mainFeatureSet = new Set(['preinstalled-snaps']);
const mainFeatureSet = new Set([]);
const flaskFeatureSet = new Set([
'flask',
'preinstalled-snaps',
Expand Down

0 comments on commit f7d8e61

Please sign in to comment.