Skip to content

Commit

Permalink
fix(deps): [email protected]>9.0.1 (#12008)
Browse files Browse the repository at this point in the history
## **Description**
Update `eth-json-rpc-middleware` from `4.3.0` (2019-10-05) to `9.0.1`
(2022-10-05).

## **Related issues**
- Preparation for #11952
- #11978

#### Blocked by
- [x] #11980

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
legobeat authored Oct 28, 2024
1 parent e7595b2 commit e958436
Show file tree
Hide file tree
Showing 5 changed files with 62 additions and 335 deletions.
3 changes: 0 additions & 3 deletions .iyarc
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
# ReDoS vulnerability, no impact to this application, and fix not backported yet to the versions we use

GHSA-c2qf-rxjj-qqgw
2 changes: 1 addition & 1 deletion app/core/BackgroundBridge/BackgroundBridge.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { SubjectType } from '@metamask/permission-controller';

const createFilterMiddleware = require('eth-json-rpc-filters');
const createSubscriptionManager = require('eth-json-rpc-filters/subscriptionManager');
const providerAsMiddleware = require('eth-json-rpc-middleware/providerAsMiddleware');
const { providerAsMiddleware } = require('eth-json-rpc-middleware');
const pump = require('pump');
// eslint-disable-next-line import/no-nodejs-modules
const EventEmitter = require('events').EventEmitter;
Expand Down
2 changes: 1 addition & 1 deletion app/core/Snaps/SnapBridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { SubjectType } from '@metamask/permission-controller';
const ObjectMultiplex = require('@metamask/object-multiplex');
const createFilterMiddleware = require('eth-json-rpc-filters');
const createSubscriptionManager = require('eth-json-rpc-filters/subscriptionManager');
const providerAsMiddleware = require('eth-json-rpc-middleware/providerAsMiddleware');
const { providerAsMiddleware } = require('eth-json-rpc-middleware');
const pump = require('pump');

interface ISnapBridgeProps {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@
"eth-block-tracker": "^7.0.1",
"eth-ens-namehash": "2.0.8",
"eth-json-rpc-filters": "^6.0.1",
"eth-json-rpc-middleware": "4.3.0",
"eth-json-rpc-middleware": "9.0.1",
"eth-url-parser": "1.0.4",
"ethereumjs-abi": "0.6.6",
"ethereumjs-util": "6.1.0",
Expand Down
Loading

0 comments on commit e958436

Please sign in to comment.