fix: hide ApprovalTagUrl when origins is internal

MetaMask · Dec 10, 2024 · 9f854c6 · 9f854c6
1 parent 800d116
commit 9f854c6
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/app/components/UI/ApprovalTagUrl/ApprovalTagUrl.test.tsx b/app/components/UI/ApprovalTagUrl/ApprovalTagUrl.test.tsx
@@ -1,10 +1,12 @@
 import React from 'react';
 import renderWithProvider from '../../../util/test/renderWithProvider';
-import ApprovalTagUrl from './ApprovalTagUrl';
+import ApprovalTagUrl, { APPROVAL_TAG_URL_ORIGIN_PILL } from './ApprovalTagUrl';
 import { backgroundState } from '../../../util/test/initial-root-state';
+import { INTERNAL_ORIGINS } from '../../../constants/transaction';
 
 const ADDRESS_MOCK = '0x1234567890abcdef1234567890abcdef12345678';
 const DOMAIN_MOCK = 'metamask.github.io';
+
 const mockInitialState = {
   settings: {},
   engine: {
@@ -19,7 +21,7 @@ const mockInitialState = {
 
 describe('ApprovalTagUrl', () => {
   it('renders correctly', () => {
-    const { toJSON } = renderWithProvider(
+    const { toJSON, getByTestId } = renderWithProvider(
       <ApprovalTagUrl
         from={ADDRESS_MOCK}
         origin={DOMAIN_MOCK}
@@ -30,5 +32,20 @@ describe('ApprovalTagUrl', () => {
     );
 
     expect(toJSON()).toMatchSnapshot();
+    expect(getByTestId(APPROVAL_TAG_URL_ORIGIN_PILL)).toBeDefined();
+  });
+
+  it('does not render when origin is an internal origin', () => {
+    const { queryByTestId } = renderWithProvider(
+      <ApprovalTagUrl
+        from={ADDRESS_MOCK}
+        origin={INTERNAL_ORIGINS[0]}
+        url={`https://${INTERNAL_ORIGINS[0]}`}
+        sdkDappMetadata={{ url: '', icon: '' }}
+      />,
+      { state: mockInitialState },
+    );
+
+    expect(queryByTestId(APPROVAL_TAG_URL_ORIGIN_PILL)).toBeNull();
   });
 });
diff --git a/app/components/UI/ApprovalTagUrl/ApprovalTagUrl.tsx b/app/components/UI/ApprovalTagUrl/ApprovalTagUrl.tsx
@@ -11,6 +11,7 @@ import { selectAccountsByChainId } from '../../../selectors/accountTrackerContro
 import { getHost, prefixUrlWithProtocol } from '../../../util/browser';
 import useFavicon from '../../hooks/useFavicon/useFavicon';
 import stylesheet from './ApprovalTagUrl.styles';
+import { INTERNAL_ORIGINS } from '../../../constants/transaction';
 
 const { ORIGIN_DEEPLINK, ORIGIN_QR_CODE } = AppConstants.DEEPLINKS;
 export const APPROVAL_TAG_URL_ORIGIN_PILL = 'APPROVAL_TAG_URL_ORIGIN_PILL';
@@ -76,7 +77,9 @@ const ApprovalTagUrl = ({
         uri: '',
       };
 
-  if (origin && !isOriginDeepLink) {
+  const showOrigin = origin && !isOriginDeepLink && !INTERNAL_ORIGINS.includes(origin);
+
+  if (showOrigin) {
     return (
       <TagUrl
         testID={APPROVAL_TAG_URL_ORIGIN_PILL}

diff --git a/app/components/UI/ApprovalTagUrl/__snapshots__/ApprovalTagUrl.test.tsx.snap b/app/components/UI/ApprovalTagUrl/__snapshots__/ApprovalTagUrl.test.tsx.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`ApprovalTagUrl renders correctly 1`] = `
+exports[`ApprovalTagUrl renders correctly when origin is not an internal origin 1`] = `
 <View
   style={
     {