Skip to content

Commit

Permalink
chore: bump {profile-sync,notification-services}-controller (#12615)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

We want to ensure that mobile is using the latest versions of all
controllers.

- Bump `@metamask/notification-services-controller` from 0.14.0 to
0.15.0 ([view
changes](https://github.com/MetaMask/core/blob/main/packages/notification-services-controller/CHANGELOG.md))
  - There are no notable changes between these versions.
- Bump `@metamask/profile-sync-controller` from 2.0.0 to 3.0.0 ([view
changes](https://github.com/MetaMask/core/blob/main/packages/profile-sync-controller/CHANGELOG.md))
- The `UserStorageController` messenger must now allow the actions
`NetworkController:getState`, `NetworkController:addNetwork`,
`NetworkController:removeNetwork`, and `NetworkController:updateNetwork`
- The `UserStorageController` messenger must now allow the event
`NetworkController:networkRemoved`

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
#12514

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
cryptodev-2s authored Dec 10, 2024
1 parent 9d63e34 commit 8ad0072
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 16 deletions.
5 changes: 5 additions & 0 deletions app/core/Engine/Engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1042,12 +1042,17 @@ export class Engine {
'NotificationServicesController:selectIsNotificationServicesEnabled',
AccountsControllerListAccountsAction,
AccountsControllerUpdateAccountMetadataAction,
'NetworkController:getState',
'NetworkController:addNetwork',
'NetworkController:removeNetwork',
'NetworkController:updateNetwork',
],
allowedEvents: [
'KeyringController:unlock',
'KeyringController:lock',
AccountsControllerAccountAddedEvent,
AccountsControllerAccountRenamedEvent,
'NetworkController:networkRemoved',
],
}),
nativeScryptCrypto: scrypt,
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,13 @@
"@metamask/logging-controller": "^6.0.1",
"@metamask/message-signing-snap": "^0.3.3",
"@metamask/network-controller": "^22.1.0",
"@metamask/notification-services-controller": "^0.14.0",
"@metamask/notification-services-controller": "^0.15.0",
"@metamask/permission-controller": "^11.0.0",
"@metamask/phishing-controller": "^12.0.3",
"@metamask/post-message-stream": "^8.0.0",
"@metamask/ppom-validator": "0.36.0",
"@metamask/preferences-controller": "^15.0.1",
"@metamask/profile-sync-controller": "^2.0.0",
"@metamask/profile-sync-controller": "^3.0.0",
"@metamask/react-native-actionsheet": "2.4.2",
"@metamask/react-native-button": "^3.0.0",
"@metamask/react-native-payments": "^2.0.0",
Expand Down
28 changes: 14 additions & 14 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4490,7 +4490,7 @@
resolved "https://registry.yarnpkg.com/@metamask/contract-metadata/-/contract-metadata-2.5.0.tgz#33921fa9c15eb1863f55dcd5f75467ae15614ebb"
integrity sha512-+j7jEcp0P1OUMEpa/OIwfJs/ahBC/akwgWxaRTSWX2SWABvlUKBVRMtslfL94Qj2wN2xw8xjaUy5nSHqrznqDA==

"@metamask/controller-utils@^11.0.0", "@metamask/controller-utils@^11.3.0", "@metamask/controller-utils@^11.4.1", "@metamask/controller-utils@^11.4.3", "@metamask/controller-utils@^11.4.4":
"@metamask/controller-utils@^11.0.0", "@metamask/controller-utils@^11.3.0", "@metamask/controller-utils@^11.4.1", "@metamask/controller-utils@^11.4.4":
version "11.4.4"
resolved "https://registry.yarnpkg.com/@metamask/controller-utils/-/controller-utils-11.4.4.tgz#6e43e4cf53d34dad225bab8aaf4e7efcb1fe7623"
integrity sha512-0/gKC6jxlj8KRzi0RjGDQnml6l4b46Da/AIqnGJMOC59zl4qD5UN1GM+mq7L5duw/m8sSHa7VbL1hL0l7Cw1pg==
Expand Down Expand Up @@ -4883,7 +4883,7 @@
uuid "^9.0.1"
webextension-polyfill "^0.12.0"

"@metamask/keyring-controller@^19.0.0", "@metamask/keyring-controller@^19.0.1":
"@metamask/keyring-controller@^19.0.1":
version "19.0.1"
resolved "https://registry.yarnpkg.com/@metamask/keyring-controller/-/keyring-controller-19.0.1.tgz#6fee40a46a780a720f4c864ea779673569be06a7"
integrity sha512-6dNQBaJanAKEg7V0ksnWyqxHY1r3YCe910OF6DpnN97NZIPx3tba2zy32jbQWGPG6XaybfTG1xdUBtdYdeTpQA==
Expand Down Expand Up @@ -4947,7 +4947,7 @@
resolved "https://registry.yarnpkg.com/@metamask/mobile-provider/-/mobile-provider-3.0.0.tgz#8a6a5a0874c8cbe4b468f63dfc57117d207f9595"
integrity sha512-XwFJk0rd9lAZR5xS3VC7ypEhD7DvZR2gi2Ch6PHnODIqeS9Te3OdVKK5+jHI4his8v/zs6LWdFdlRtx5/jL96w==

"@metamask/network-controller@^22.0.2", "@metamask/network-controller@^22.1.0":
"@metamask/network-controller@^22.1.0":
version "22.1.0"
resolved "https://registry.yarnpkg.com/@metamask/network-controller/-/network-controller-22.1.0.tgz#b4c81a31fc52147d12131bfb16c77c1c1cfbe43c"
integrity sha512-wvP2HUBQCWvlvBkuhqMNtd6+D/cJa343ABFLfCLNrQsk8QjdHPFw/QDIqC+QXTPxyrPWw9GL5akaLb//rmO1NA==
Expand Down Expand Up @@ -4979,14 +4979,14 @@
"@ethersproject/providers" "^5.7.2"
async-mutex "^0.3.1"

"@metamask/notification-services-controller@^0.14.0":
version "0.14.0"
resolved "https://registry.yarnpkg.com/@metamask/notification-services-controller/-/notification-services-controller-0.14.0.tgz#c2699db0c9e3329c2654a4a39d14176009963eaa"
integrity sha512-/OJW4j8PY66Gil+I/sJxstqXlR8ug+enOn1mCu0eqTDUwlrY+Qb3jOzww5mTWwN2q8D9IhkOHZm7HkM9dSWGSw==
"@metamask/notification-services-controller@^0.15.0":
version "0.15.0"
resolved "https://registry.yarnpkg.com/@metamask/notification-services-controller/-/notification-services-controller-0.15.0.tgz#d846fa49df62838a8ae48e80a8fee098730f06b0"
integrity sha512-RJtCI0GkVLStmhNoq9QNqSQNag6gD37iWU/qU19ds5PujSrtmfS5t2Sk6YRNV3SkRrfiIFrhGDToUDBDBu13OA==
dependencies:
"@contentful/rich-text-html-renderer" "^16.5.2"
"@metamask/base-controller" "^7.0.2"
"@metamask/controller-utils" "^11.4.3"
"@metamask/controller-utils" "^11.4.4"
"@metamask/utils" "^10.0.0"
bignumber.js "^9.1.2"
firebase "^10.11.0"
Expand Down Expand Up @@ -5105,15 +5105,15 @@
"@metamask/base-controller" "^7.0.2"
"@metamask/controller-utils" "^11.4.4"

"@metamask/profile-sync-controller@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@metamask/profile-sync-controller/-/profile-sync-controller-2.0.0.tgz#140297d4608373501b8dbe6fd86cbe3e63cdcc41"
integrity sha512-HdMlIz3Iun9wESUVcaH3y1pKNcnH+DJD0J0OKVaUxk4oKpS+u0QauEaMbvNps1ZxAY23x9gXTzeE3MMLbXYLgw==
"@metamask/profile-sync-controller@^3.0.0":
version "3.0.0"
resolved "https://registry.yarnpkg.com/@metamask/profile-sync-controller/-/profile-sync-controller-3.0.0.tgz#52cdb1f370ba6c8ce580fb9f9d1e9a5b1f8b9014"
integrity sha512-OlNOlWcHLlX4QNKR/J0O4IwgtO46EYA3OPzntmDk7zlFtd3I61qooE3EnRWH6aYPQsf7GcsM2aP44cKVJyV4mg==
dependencies:
"@metamask/base-controller" "^7.0.2"
"@metamask/keyring-api" "^10.1.0"
"@metamask/keyring-controller" "^19.0.0"
"@metamask/network-controller" "^22.0.2"
"@metamask/keyring-controller" "^19.0.1"
"@metamask/network-controller" "^22.1.0"
"@metamask/snaps-sdk" "^6.7.0"
"@metamask/snaps-utils" "^8.3.0"
"@noble/ciphers" "^0.5.2"
Expand Down

0 comments on commit 8ad0072

Please sign in to comment.